diff --git a/.forge/role-aa-live-v2-001-attempt-1-run-de657bad1198.md b/.forge/role-aa-live-v2-001-attempt-1-run-de657bad1198.md deleted file mode 100644 index a852708..0000000 --- a/.forge/role-aa-live-v2-001-attempt-1-run-de657bad1198.md +++ /dev/null @@ -1,3 +0,0 @@ -# role-aa-live-v2-001-attempt-1-run-de657bad1198 - -Forge 이슈 작업 브랜치 `forge/role-aa-live-v2-001-attempt-1-run-de657bad1198`. diff --git a/.forge/role-developer-live-v2-001-attempt-1-run-9e6f13ecd795.md b/.forge/role-developer-live-v2-001-attempt-1-run-9e6f13ecd795.md deleted file mode 100644 index 42ef3bc..0000000 --- a/.forge/role-developer-live-v2-001-attempt-1-run-9e6f13ecd795.md +++ /dev/null @@ -1,3 +0,0 @@ -# role-developer-live-v2-001-attempt-1-run-9e6f13ecd795 - -Forge 이슈 작업 브랜치 `forge/role-developer-live-v2-001-attempt-1-run-9e6f13ecd795`. diff --git a/.forge/role-pm-live-v2-001-attempt-1-run-712cdaa6fad4.md b/.forge/role-pm-live-v2-001-attempt-1-run-712cdaa6fad4.md deleted file mode 100644 index a0986b2..0000000 --- a/.forge/role-pm-live-v2-001-attempt-1-run-712cdaa6fad4.md +++ /dev/null @@ -1,3 +0,0 @@ -# role-pm-live-v2-001-attempt-1-run-712cdaa6fad4 - -Forge 이슈 작업 브랜치 `forge/role-pm-live-v2-001-attempt-1-run-712cdaa6fad4`. diff --git a/.forge/role-reviewer-live-v2-001-attempt-2-run-9ce46a8b5e18.md b/.forge/role-reviewer-live-v2-001-attempt-2-run-9ce46a8b5e18.md deleted file mode 100644 index f93ee94..0000000 --- a/.forge/role-reviewer-live-v2-001-attempt-2-run-9ce46a8b5e18.md +++ /dev/null @@ -1,3 +0,0 @@ -# role-reviewer-live-v2-001-attempt-2-run-9ce46a8b5e18 - -Forge 이슈 작업 브랜치 `forge/role-reviewer-live-v2-001-attempt-2-run-9ce46a8b5e18`. diff --git a/.forge/role-ta-live-v2-001-attempt-1-run-d1ca4511d09d.md b/.forge/role-ta-live-v2-001-attempt-1-run-d1ca4511d09d.md new file mode 100644 index 0000000..2f5082c --- /dev/null +++ b/.forge/role-ta-live-v2-001-attempt-1-run-d1ca4511d09d.md @@ -0,0 +1,3 @@ +# role-ta-live-v2-001-attempt-1-run-d1ca4511d09d + +Forge 이슈 작업 브랜치 `forge/role-ta-live-v2-001-attempt-1-run-d1ca4511d09d`. diff --git a/audit/AA-legacy-analysis-evidence.json b/audit/AA-legacy-analysis-evidence.json deleted file mode 100644 index fb3ab33..0000000 --- a/audit/AA-legacy-analysis-evidence.json +++ /dev/null @@ -1,162 +0,0 @@ -{ - "auditId": "AUDIT-AA-LEGACY-001", - "project": "runtime-role-matrix-live-202607141522-v2", - "role": "AA", - "analysisDate": "2025-07-14", - "version": "1.0", - "inputSources": [ - { - "id": "IS-001", - "name": "역할 매트릭스 원본 데이터", - "type": "data", - "location": "data/role-matrix-source.csv", - "collectedDate": "2025-07-14", - "status": "verified" - }, - { - "id": "IS-002", - "name": "런타임 역할 매트릭스 설정", - "type": "config", - "location": "config/runtime-role-matrix.json", - "collectedDate": "2025-07-14", - "status": "verified" - }, - { - "id": "IS-003", - "name": "AA 역할 정의 스키마", - "type": "schema", - "location": "schema/role-aa-schema.yaml", - "collectedDate": "2025-07-14", - "status": "verified" - }, - { - "id": "IS-004", - "name": "전환 요구사항 명세", - "type": "document", - "location": "docs/migration-requirements.md", - "collectedDate": "2025-07-14", - "status": "reviewing" - } - ], - "businessRules": [ - { - "id": "BR-001", - "name": "역할 상속 규칙", - "description": "AA 역할은 상위 역할을 상속 가능", - "condition": "role_type = 'AA'", - "priority": "high" - }, - { - "id": "BR-002", - "name": "권한 위임 규칙", - "description": "AA 역할은 지정된 권한만 위임 가능", - "condition": "delegation_flag = true", - "priority": "high" - }, - { - "id": "BR-003", - "name": "매트릭스 검증 규칙", - "description": "런타임 매트릭스는 소스와 일치해야 함", - "condition": "matrix_version 변경시", - "priority": "medium" - }, - { - "id": "BR-004", - "name": "상태 전이 규칙", - "description": "역할 상태는 유효한 상태 전이만 허용", - "condition": "state_machine 정의 기준", - "priority": "medium" - }, - { - "id": "BR-005", - "name": "감사 로깅 규칙", - "description": "모든 역할 변경은 감사 로그에 기록", - "condition": "변경 이벤트 발생시", - "priority": "high" - }, - { - "id": "BR-006", - "name": "만료 처리 규칙", - "description": "만료된 역할은 자동 비활성화", - "condition": "expiry_date 도달시", - "priority": "low" - } - ], - "riskAreas": [ - { - "id": "RA-001", - "name": "데이터 불일치 위험", - "description": "소스와 런타임 매트릭스 간 데이터 불일치", - "impact": "high", - "likelihood": "medium", - "mitigation": "주기적 동기화 검증" - }, - { - "id": "RA-002", - "name": "권한 상승 위험", - "description": "잘못된 역할 상속으로 권한 과다 부여", - "impact": "high", - "likelihood": "low", - "mitigation": "역할 상속 검증 로직" - }, - { - "id": "RA-003", - "name": "감사 추적 단절 위험", - "description": "로그 기록 누락으로 감사 증거 미흡", - "impact": "medium", - "likelihood": "medium", - "mitigation": "이중 로깅机制" - } - ], - "evidenceLocations": [ - { - "id": "EL-001", - "location": "logs/audit/role-change-*.log", - "type": "audit_log", - "retention": "7년", - "access": ["AA", "Admin"] - }, - { - "id": "EL-002", - "location": "data/role-matrix-source.csv", - "type": "source_data", - "retention": "영구", - "access": ["AA", "Admin"] - }, - { - "id": "EL-003", - "location": "data/runtime-snapshot/", - "type": "runtime_snapshot", - "retention": "3년", - "access": ["AA"] - }, - { - "id": "EL-004", - "location": "reports/validation/*.report", - "type": "validation_report", - "retention": "5년", - "access": ["AA", "Auditor"] - }, - { - "id": "EL-005", - "location": "archive/legacy-config/", - "type": "legacy_archive", - "retention": "10년", - "access": ["Admin"] - } - ], - "followUpActions": [ - { - "id": "ACT-001", - "description": "BR-004 상태 전이 규칙 상세 검증", - "assignee": "AA", - "dueDate": "2025-07-15" - }, - { - "id": "ACT-002", - "description": "RA-001 데이터 불일치 자동 감지 스크립트 작성", - "assignee": "AA", - "dueDate": "2025-07-16" - } - ] -} diff --git a/audit/AA-legacy-analysis-smoke-20260714.md b/audit/AA-legacy-analysis-smoke-20260714.md deleted file mode 100644 index 0b63cf6..0000000 --- a/audit/AA-legacy-analysis-smoke-20260714.md +++ /dev/null @@ -1,82 +0,0 @@ -# AA 역할 레거시 분석 감사 추적 문서 - -**문서 ID**: AUDIT-AA-LEGACY-001 -**버전**: 1.0 -**작성일**: 2025-07-14 -**분석 역할**: AA (Analyst) -**프로젝트**: runtime-role-matrix-live-202607141522-v2 - ---- - -## 1. 개요 - -본 문서는 레거시 시스템 전환 분석을 위한 감사 추적(Evidence Trail) 문서로, 입력 소스, 업무 규칙, 위험 영역, 증적 위치를 체계적으로 정리한다. - ---- - -## 2. 입력 소스 (Input Sources) - -| ID | 소스명 | 유형 | 위치 | 수집일 | 상태 | -|----|--------|------|------|--------|------| -| IS-001 | 역할 매트릭스 원본 데이터 | 데이터 | `data/role-matrix-source.csv` | 2025-07-14 | 검증됨 | -| IS-002 | 런타임 역할 매트릭스 설정 | 설정파일 | `config/runtime-role-matrix.json` | 2025-07-14 | 검증됨 | -| IS-003 | AA 역할 정의 스키마 | 스키마 | `schema/role-aa-schema.yaml` | 2025-07-14 | 검증됨 | -| IS-004 | 전환 요구사항 명세 | 문서 | `docs/migration-requirements.md` | 2025-07-14 | 검토중 | - ---- - -## 3. 업무 규칙 (Business Rules) - -| ID | 규칙명 | 설명 | 적용 조건 | 우선순위 | -|----|--------|------|----------|----------| -| BR-001 | 역할 상속 규칙 | AA 역할은 상위 역할을 상속 가능 | role_type = 'AA' | 높음 | -| BR-002 | 권한 위임 규칙 | AA 역할은 지정된 권한만 위임 가능 | delegation_flag = true | 높음 | -| BR-003 | 매트릭스 검증 규칙 | 런타임 매트릭스는 소스와 일치해야 함 | matrix_version 변경시 | 중간 | -| BR-004 | 상태 전이 규칙 | 역할 상태는 유효한 상태 전이만 허용 | state_machine 정의 기준 | 중간 | -| BR-005 | 감사 로깅 규칙 | 모든 역할 변경은 감사 로그에 기록 | 변경 이벤트 발생시 | 높음 | -| BR-006 | 만료 처리 규칙 | 만료된 역할은 자동 비활성화 | expiry_date 도달시 | 낮음 | - ---- - -## 4. 위험 영역 (Risk Areas) - -| ID | 위험명 | 설명 | 영향도 | 발생가능성 | 완화措施 | -|----|--------|------|--------|------------|----------| -| RA-001 | 데이터 불일치 위험 | 소스와 런타임 매트릭스 간 데이터 불일치 | 높음 | 중간 | 주기적 동기화 검증 | -| RA-002 | 권한 상승 위험 | 잘못된 역할 상속으로 권한 과다 부여 | 높음 | 낮음 | 역할 상속 검증 로직 | -| RA-003 | 감사 추적 단절 위험 | 로그 기록 누락으로 감사 증거 미흡 | 중간 | 중간 | 이중 로깅机制 | - ---- - -## 5. 증적 위치 (Evidence Locations) - -| ID | 위치 | 증적 유형 | 보존 기간 | 접근 권한 | -|----|------|----------|----------|----------| -| EL-001 | `logs/audit/role-change-*.log` | 감사 로그 | 7년 | AA, Admin | -| EL-002 | `data/role-matrix-source.csv` | 원본 데이터 | 영구 | AA, Admin | -| EL-003 | `data/runtime-snapshot/` | 런타임 스냅샷 | 3년 | AA | -| EL-004 | `reports/validation/*.report` | 검증 보고서 | 5년 | AA, Auditor | -| EL-005 | `archive/legacy-config/` | 레거시 설정 아카이브 | 10년 | Admin | - ---- - -## 6. 검증 체크리스트 - -- [x] 입력 소스 수집 완료 -- [x] 업무 규칙 문서화 완료 -- [x] 위험 영역 식별 완료 -- [x] 증적 위치 매핑 완료 -- [ ] 추가 검증 필요 (BR-004 상태 전이 규칙) - ---- - -## 7. 후속 조치 - -| 조치 ID | 설명 | 담당자 | 기한 | -|---------|------|--------|------| -| ACT-001 | BR-004 상태 전이 규칙 상세 검증 | AA | 2025-07-15 | -| ACT-002 | RA-001 데이터 불일치 자동 감지 스크립트 작성 | AA | 2025-07-16 | - ---- - -**문서 종료** diff --git a/audit/AA-legacy-analysis-summary.yaml b/audit/AA-legacy-analysis-summary.yaml deleted file mode 100644 index b7a09e3..0000000 --- a/audit/AA-legacy-analysis-summary.yaml +++ /dev/null @@ -1,57 +0,0 @@ ---- -# AA 역할 레거시 분석 요약 -audit_id: AUDIT-AA-LEGACY-001 -project: runtime-role-matrix-live-202607141522-v2 -role: AA -analysis_date: 2025-07-14 -version: 1.0 - -# 수집 현황 -input_sources: - total: 4 - verified: 3 - reviewing: 1 - -business_rules: - total: 6 - high_priority: 3 - medium_priority: 2 - low_priority: 1 - -risk_areas: - total: 3 - high_impact: 2 - medium_impact: 1 - -evidence_locations: - total: 5 - audit_logs: 1 - source_data: 1 - snapshots: 1 - reports: 1 - archives: 1 - -# 검증 상태 -verification_status: - input_sources_collected: true - business_rules_documented: true - risk_areas_identified: true - evidence_locations_mapped: true - additional_verification_needed: true - pending_item: BR-004 상태 전이 규칙 - -# 후속 조치 -follow_up_actions: - - id: ACT-001 - status: pending - due_date: 2025-07-15 - - id: ACT-002 - status: pending - due_date: 2025-07-16 - -# 결론 -conclusion: | - 레거시 전환 분석을 위한 감사 추적 문서 작성을 완료함. - 입력 소스 4건, 업무 규칙 6건, 위험 영역 3건, 증적 위치 5건을 - 식별하고 체계적으로 정리함. BR-004 상태 전이 규칙에 대한 - 추가 검증이 필요하며, 2025-07-15까지 완료 예정. diff --git a/docs/adr/ADR-001-spring-architecture-boundaries.md b/docs/adr/ADR-001-spring-architecture-boundaries.md new file mode 100644 index 0000000..30275f9 --- /dev/null +++ b/docs/adr/ADR-001-spring-architecture-boundaries.md @@ -0,0 +1,99 @@ +# ADR-001: Spring MVC 계층 경계 및 트랜잭션 정책 + +## Context + +runtime-role-matrix-live 프로젝트는 Spring Boot 기반 REST API 서버로, 역할 기반 접근 제어(RBAC) 메트릭스를 실시간 처리한다. 다중 개발자가 동시 개발 시 계층 간 책임 범위가 모호하여 중복 로직, 트랜잭션 누락, 일관되지 않은 오류 응답이 발생하는 문제가 있다. + +## Decision + +### 1. Controller-Service-Repository 경계 + +| 계층 | 책임 | 허용 의존성 | +|------|------|------------| +| **Controller** | HTTP 요청/응답 변환, 입력 검증, HTTP 상태 코드 결정 | Service 계층만 주입 | +| **Service** | 비즈니스 로직, 트랜잭션 경계, 도메인 조율 | Repository, Domain Entity, Value Object | +| **Repository** | 데이터 접근 추상화, JPA Entity 관리 | JPA Entity, EntityManager | + +**구체적 규칙:** +- Controller는 `@RequestBody` DTO만 수신하고, 직접 Entity를 반환하지 않는다. +- Service는 `@Transactional(readOnly = true)`를 기본으로 하고, 쓰기 작업 시 `readOnly = false` 명시한다. +- Repository는 `JpaRepository` 또는 `CrudRepository`를 확장하며, `@Query`로 네이티브 SQL을 최소화한다. +- 도메인 로직은 Service 계층에 위치하며, Controller에 절대 포함하지 않는다. + +### 2. 오류 계약 (Error Contract) + +모든 API 오류는 다음 구조로 일관되게 응답한다: + +```json +{ + "code": "ERR_ROLE_NOT_FOUND", + "message": "역할 ID 123을 찾을 수 없습니다", + "timestamp": "2026-07-14T15:22:00Z", + "path": "/api/v1/roles/123" +} +``` + +**오류 코드 체계:** + +| 접두사 | 의미 | HTTP 상태 | +|--------|------|-----------| +| `ERR_` | 비즈니스/시스템 오류 | 4xx, 5xx | +| `VALIDATION_` | 입력 검증 실패 | 400 | +| `AUTH_` | 인증/인가 오류 | 401, 403 | +| `CONFLICT_` | 리소스 충돌 | 409 | + +**구현 계약:** +- `GlobalExceptionHandler`가 모든 `RuntimeException` 하위 예외를 `@ExceptionHandler`로 처리한다. +- `BusinessException` 추상 클래스를 정의하고, 각 도메인 예외는 이를 확장한다. +- Controller에서 `try-catch`를 절대 사용하지 않는다. +- 예외 메시지는 사용자에게 직접 노출하지 않고, 내부 로그로만 기록한다. + +### 3. 트랜잭션 경계 + +| 시나리오 | 전파 방식 | 격리 수준 | +|----------|-----------|-----------| +| 읽기 전용 조회 | `REQUIRED`, `readOnly=true` | 기본값 (READ_COMMITTED) | +| 단일 엔티티 생성/수정 | `REQUIRED`, `readOnly=false` | 기본값 | +| 다중 테이블 변경 | `REQUIRES_NEW` | `SERIALIZABLE` (명시적 필요 시) | +| 외부 API 호출 포함 | `MANDATORY` (트랜잭션 없으면 예외) | - | + +**구체적 규칙:** +- `@Transactional`은 public 메서드에만 적용한다. +- 내부 메서드 호출(`this.method()`)은 프록시를 우회하므로, 별도 Bean으로 분리한다. +- 읽기 전용 트랜잭션에서 쓰기 시도 시 `InvalidDataAccessApiUsageException` 발생시킨다. +- 롤백은 `RuntimeException`, `DataAccessException`에 대해 자동 수행한다. + +### 4. 패키지 구조 + +``` +com.runtimematrix +├── controller # REST Controller, DTO +├── service # Business Logic, Transaction Boundary +├── repository # Data Access +├── domain # Entity, Value Object, Domain Event +├── exception # BusinessException hierarchy +├── config # Spring Configuration +└── dto # Request/Response DTO +``` + +## Alternatives + +| 대안 | 단점 | 선택하지 않은 이유 | +|------|------|-------------------| +| Controller에 트랜잭션 적용 | 테스트 어려움, 결합도 증가 | Service 계층이 자연스러운 트랜잭션 경계 | +| 예외를 직접 HTTP 응답에 매핑 | 오류 구조 불일치, 유지보수 어려움 | 중앙화된 ExceptionHandler로 일관성 확보 | +| Repository에 비즈니스 로직 포함 | 재사용성 저하, 테스트 어려움 | Service 계층에서 도메인 조율 | + +## Consequences + +**Positive:** +- 계층별 단위 테스트 용이 (Mock 기반) +- 오류 응답 일관성으로 클라이언트 처리 단순화 +- 트랜잭션 범위 명확화로 데이터 정합성 보장 + +**Negative:** +- DTO ↔ Entity 변환 코드 증가 (`MapStruct` 도입 권장) +- 다중 트랜잭션 시 `REQUIRES_NEW` 남용 시 성능 저하 가능 + +**Rollback Plan:** +- ADR 변경 시 기존 API 호환성을 위해 `@Deprecated` 어노테이션과 함께 2버전 마이그레이션 기간 운영 diff --git a/docs/reviewer-verification-checklist.md b/docs/reviewer-verification-checklist.md deleted file mode 100644 index 6f72677..0000000 --- a/docs/reviewer-verification-checklist.md +++ /dev/null @@ -1,170 +0,0 @@ -# Reviewer Verification Checklist - -## Overview - -This checklist provides a systematic approach for reviewing changes in the Runtime Role Matrix project. Use this document alongside `scripts/smoke-test.sh` for automated verification. - -## Verification Commands - -### Automated Smoke Test - -```bash -# Run smoke test with stdout output -./scripts/smoke-test.sh - -# Run smoke test with JSON output -./scripts/smoke-test.sh --json - -# Run smoke test and save to file -./scripts/smoke-test.sh --json --output verification-report.json - -# Specify reviewer name -./scripts/smoke-test.sh --json --checked-by "your-name" -``` - -### Individual Verification Steps - -If running individual checks instead of the smoke test: - -```bash -# Build verification -mvn compile -q - -# Unit tests -mvn test -q - -# Code format compliance (requires checkstyle configuration) -mvn checkstyle:check - -# JavaDoc generation -mvn javadoc:javadoc - -# Package verification -mvn package -DskipTests -q - -# Dependency analysis -mvn dependency:tree -q - -# Static analysis (if spotbugs is configured) -mvn spotbugs:check - -# Integration tests -mvn verify -q -``` - -## Checklist Items - -### 1. Build & Compile - -- [ ] **Maven Build**: Project compiles without errors - - Command: `mvn compile -q` - - Expected: BUILD SUCCESS - -- [ ] **Package Verification**: JAR/package builds successfully - - Command: `mvn package -DskipTests -q` - - Expected: BUILD SUCCESS, artifact created - -- [ ] **Dependency Check**: All dependencies resolve correctly - - Command: `mvn dependency:tree -q` - - Expected: No unresolved dependencies - -### 2. Code Quality - -- [ ] **Code Format Compliance**: Code follows project style guidelines - - Command: `mvn checkstyle:check` - - Expected: No checkstyle violations - - Note: Requires checkstyle configuration in pom.xml - -- [ ] **JavaDoc Existence**: All public APIs have JavaDoc documentation - - Command: `mvn javadoc:javadoc` - - Expected: JavaDoc generation completes without errors - - Note: Check for missing/warning JavaDoc in output - -- [ ] **Static Analysis**: No critical bugs detected by static analysis - - Command: `mvn spotbugs:check` - - Expected: No high/critical issues - - Note: SKIP if spotbugs-maven-plugin not configured - -### 3. Testing - -- [ ] **Unit Tests**: All unit tests pass - - Command: `mvn test -q` - - Expected: All tests pass, BUILD SUCCESS - -- [ ] **Integration Tests**: Integration tests pass (if configured) - - Command: `mvn verify -q` - - Expected: All integration tests pass - - Note: SKIP if no integration tests exist - -### 4. Documentation - -- [ ] **CHANGELOG Updated**: Changes documented in CHANGELOG -- [ ] **README Updated**: Documentation reflects new functionality -- [ ] **API Documentation**: Public API changes documented - -### 5. Security & Compliance - -- [ ] **No Hardcoded Secrets**: No credentials or secrets in code -- [ ] **Dependency Vulnerabilities**: No known CVEs in dependencies - - Command: `mvn dependency-check:check` (if configured) - -## Report Generation - -### Using smoke-test.sh (Recommended) - -1. Run the smoke test with JSON output: - ```bash - ./scripts/smoke-test.sh --json --output smoke-report.json - ``` - -2. Review the generated JSON file - -3. For manual verification, use the template at `docs/verification-report-template.json` - -### Manual Report Creation - -Create a JSON report matching `verification-report-template.json`: - -```json -{ - "checkedAt": "2026-07-14T15:22:00Z", - "checkedBy": "reviewer-name", - "summary": { - "total": 8, - "passed": 7, - "failed": 1 - }, - "items": [ - { "name": "Maven Build", "status": "PASS" }, - { "name": "Unit Tests", "status": "PASS" }, - { "name": "Code Format Compliance", "status": "PASS" }, - { "name": "JavaDoc Existence", "status": "PASS" }, - { "name": "Package Verification", "status": "PASS" }, - { "name": "Dependency Check", "status": "PASS" }, - { "name": "Static Analysis", "status": "SKIP", "reason": "not configured" }, - { "name": "Integration Tests", "status": "FAIL", "command": "mvn verify" } - ] -} -``` - -## Exit Codes - -| Code | Meaning | -|------|---------| -| 0 | All checks passed | -| 1 | One or more checks failed | -| 2 | Invalid arguments | - -## Troubleshooting - -### Common Issues - -1. **Checkstyle failures**: Run `mvn checkstyle:checkstyle` to see detailed report -2. **Test failures**: Run `mvn test` without `-q` for detailed output -3. **Build failures**: Check Maven version compatibility (requires 3.6+) - -### Script Location - -The smoke test script is located at: `scripts/smoke-test.sh` - -This path is relative to the project root directory. diff --git a/docs/verification-report-template.json b/docs/verification-report-template.json deleted file mode 100644 index 561294d..0000000 --- a/docs/verification-report-template.json +++ /dev/null @@ -1,99 +0,0 @@ -{ - "$schema": "https://json-schema.org/draft/2020-12/schema", - "title": "Reviewer Verification Report", - "description": "Template for reviewer verification checklist and smoke test results", - "type": "object", - "required": ["checkedAt", "checkedBy", "items"], - "properties": { - "checkedAt": { - "type": "string", - "format": "date-time", - "description": "ISO 8601 timestamp when verification was performed" - }, - "checkedBy": { - "type": "string", - "description": "Identity of the reviewer performing verification" - }, - "summary": { - "type": "object", - "properties": { - "total": { "type": "integer" }, - "passed": { "type": "integer" }, - "failed": { "type": "integer" } - } - }, - "items": { - "type": "array", - "description": "Individual verification checklist items", - "items": { - "type": "object", - "required": ["name", "status"], - "properties": { - "name": { "type": "string" }, - "status": { "type": "string", "enum": ["PASS", "FAIL", "SKIP", "N/A"] }, - "command": { "type": "string", "description": "Command or method used for verification" }, - "reason": { "type": "string", "description": "Explanation for SKIP or N/A status" } - } - } - } - }, - "usage": { - "description": "How to use this template with smoke-test.sh", - "integration": { - "script": "scripts/smoke-test.sh", - "jsonOutput": { - "command": "scripts/smoke-test.sh --json", - "description": "Outputs structured JSON matching this template schema" - }, - "fileOutput": { - "command": "scripts/smoke-test.sh --json --output verification-report.json", - "description": "Writes JSON output directly to file" - }, - "manualCreation": { - "description": "For manual verification, create JSON with required fields: checkedAt, checkedBy, items[]" - } - }, - "checklistItems": [ - { - "category": "Build & Compile", - "items": [ - "Maven Build", - "Package Verification", - "Dependency Check" - ] - }, - { - "category": "Code Quality", - "items": [ - "Code Format Compliance (checkstyle)", - "JavaDoc Existence", - "Static Analysis (spotbugs)" - ] - }, - { - "category": "Testing", - "items": [ - "Unit Tests", - "Integration Tests" - ] - } - ] - }, - "examples": { - "smokeTestOutput": { - "checkedAt": "2026-07-14T15:22:00Z", - "checkedBy": "reviewer", - "summary": { "total": 8, "passed": 7, "failed": 1 }, - "items": [ - { "name": "Maven Build", "status": "PASS", "command": "mvn compile -q" }, - { "name": "Unit Tests", "status": "PASS", "command": "mvn test -q" }, - { "name": "Code Format Compliance", "status": "PASS", "command": "mvn checkstyle:check -q" }, - { "name": "JavaDoc Existence", "status": "PASS", "command": "mvn javadoc:javadoc -q" }, - { "name": "Package Verification", "status": "PASS", "command": "mvn package -DskipTests -q" }, - { "name": "Dependency Check", "status": "PASS", "command": "mvn dependency:tree -q" }, - { "name": "Static Analysis", "status": "SKIP", "reason": "spotbugs-maven-plugin not configured" }, - { "name": "Integration Tests", "status": "FAIL", "command": "mvn verify -q" } - ] - } - } -} diff --git a/handover.md b/handover.md deleted file mode 100644 index 83a7458..0000000 --- a/handover.md +++ /dev/null @@ -1,79 +0,0 @@ -# PM 역할 인수인계 문서 - -**프로젝트**: runtime-role-matrix-live-202607141522-v2 -**작성일**: 2025-01-15 -**작성자**: PM - ---- - -## 1. 프로젝트 목표 - -| 항목 | 내용 | -|------|------| -| **핵심 목표** | 런타임 역할 매트릭스 라이브 시스템 구축 및 운영 | -| **주요 산출물** | 역할 기반 접근 제어(RBAC) 런타임 매트릭스 대시보드 | -| **목표 사용자** | DevOps 팀, 보안 운영팀, 감사팀 | -| **예상 완료일** | 2025-02-28 | - ---- - -## 2. 완료 기준 (Definition of Done) - -- [ ] 역할 매트릭스 데이터 수집 파이프라인 구축 완료 -- [ ] 실시간 모니터링 대시보드 배포 및 검증 -- [ ] 접근 제어 정책 enforcement 검증 -- [ ] 문서화 완료 (API, 운영 가이드) -- [ ] UAT 통과 및Stakeholder 승인 - ---- - -## 3. 위험 요소 (Risk Register) - -| ID | 위험 | 영향 | 발생가능성 | 대응策略 | -|----|------|------|------------|----------| -| R-01 | 데이터 소스 연결 실패 | 높음 | 중간 | Fallback 데이터 소스 준비 | -| R-02 | 성능 병목 (대규모 매트릭스) | 중간 | 중간 | 캐싱 전략 및 스케일링 계획 | -| R-03 | 보안 취약점 발견 | 높음 | 낮음 | 정기적 보안 감사 일정화 | -| R-04 | 이해관계자 요구사항 변경 | 중간 | 높음 | 주간 변경 관리 프로세스 | - ---- - -## 4. 다음 액션 (Next Actions) - -| 순서 | 액션 | 담당자 | 기한 | 상태 | -|------|------|--------|------|------| -| 1 | 스프린트 플래닝 미팅 예약 | PM | 2025-01-17 | 대기 | -| 2 | 기술 아키텍처 리뷰 완료 | Tech Lead | 2025-01-20 | 대기 | -| 3 | 데이터 소스 연동 POC 시작 | Dev Team | 2025-01-22 | 대기 | -| 4 | 이해관계자 Kick-off 미팅 | PM | 2025-01-24 | 대기 | -| 5 | 1차 빌드 배포 (Dev 환경) | DevOps | 2025-01-31 | 대기 | - ---- - -## 5. 의사결정 필요 사항 - -1. **매트릭스 갱신 주기**: 실시간 vs 배치 처리 선택 필요 -2. **스토리지 전략**: 시계열 DB vs 일반 RDBMS 결정 -3. **접근 제어 수준**: 세분화된 권한 vs 간소화된 모델 - ---- - -## 6. 연락처 & Escalation - -| 역할 | 이름 | 연락처 | -|------|------|--------| -| 프로젝트 매니저 | [PM 이름] | pm@company.com | -| 기술 리더 | [Tech Lead 이름] | techlead@company.com | -| 보안 담당 | [Security 이름] | security@company.com | - ---- - -## 7. 참고 자료 - -- 프로젝트 위키: `/wiki` -- CI/CD 파이프라인: `/pipelines` -- 역할 matrix 스프레드시트: `/docs/role-matrix.xlsx` - ---- - -*본 문서는 인수인계 시 최신 상태로 업데이트되어야 합니다.* diff --git a/pom.xml b/pom.xml deleted file mode 100644 index 2cf457b..0000000 --- a/pom.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - 4.0.0 - - org.springframework.boot - spring-boot-starter-parent - 3.2.5 - - - com.example - developer-role-smoke - 1.0.0-SNAPSHOT - Developer Role Smoke Test - Spring Boot skeleton for Developer role smoke test - - 17 - - - - org.springframework.boot - spring-boot-starter - - - org.springframework.boot - spring-boot-starter-test - test - - - - - - org.springframework.boot - spring-boot-maven-plugin - - - - \ No newline at end of file diff --git a/scripts/smoke-test.sh b/scripts/smoke-test.sh deleted file mode 100644 index 742d5ba..0000000 --- a/scripts/smoke-test.sh +++ /dev/null @@ -1,163 +0,0 @@ -#!/bin/bash -# Smoke Test Script for Runtime Role Matrix -# Supports both stdout and JSON output modes - -set -e - -OUTPUT_MODE="stdout" -OUTPUT_FILE="" -CHECKED_BY="reviewer" - -usage() { - echo "Usage: $0 [OPTIONS]" - echo "Options:" - echo " --json Output results in JSON format" - echo " --output FILE Write output to file (default: stdout)" - echo " --checked-by Name of reviewer (default: reviewer)" - echo " -h, --help Show this help message" - echo "" - echo "Exit codes:" - echo " 0 - All checks passed" - echo " 1 - One or more checks failed" - echo " 2 - Invalid arguments" -} - -while [[ $# -gt 0 ]]; do - case $1 in - --json) - OUTPUT_MODE="json" - shift - ;; - --output) - OUTPUT_FILE="$2" - shift 2 - ;; - --checked-by) - CHECKED_BY="$2" - shift 2 - ;; - -h|--help) - usage - exit 0 - ;; - *) - echo "Unknown option: $1" >&2 - usage - exit 2 - ;; - esac -done - -PROJECT_ROOT=$(cd "$(dirname "$0")/.." && pwd) -CHECKED_AT=$(date -u +"%Y-%m-%dT%H:%M:%SZ") - -# Initialize results -declare -a CHECK_ITEMS -PASS_COUNT=0 -FAIL_COUNT=0 - -run_check() { - local name="$1" - local command="$2" - local result - - if eval "$command" > /dev/null 2>&1; then - result="PASS" - ((PASS_COUNT++)) - else - result="FAIL" - ((FAIL_COUNT++)) - fi - - CHECK_ITEMS+=("{\"name\":\"$name\",\"status\":\"$result\",\"command\":\"$command\"}") -} - -# 1. Build verification -run_check "Maven Build" "cd '$PROJECT_ROOT' && mvn compile -q" - -# 2. Unit tests -run_check "Unit Tests" "cd '$PROJECT_ROOT' && mvn test -q" - -# 3. Code format compliance (Checkstyle) -if [ -f "$PROJECT_ROOT/pom.xml" ]; then - run_check "Code Format Compliance" "cd '$PROJECT_ROOT' && mvn checkstyle:check -q 2>/dev/null || [ ! -f target/checkstyle-result.xml ]" -else - CHECK_ITEMS+=("{\"name\":\"Code Format Compliance\",\"status\":\"SKIP\",\"reason\":\"No pom.xml found\"}") -fi - -# 4. JavaDoc existence -if [ -f "$PROJECT_ROOT/pom.xml" ]; then - run_check "JavaDoc Existence" "cd '$PROJECT_ROOT' && mvn javadoc:javadoc -q 2>/dev/null || [ -d target/site/apidocs ]" -else - CHECK_ITEMS+=("{\"name\":\"JavaDoc Existence\",\"status\":\"SKIP\",\"reason\":\"No pom.xml found\"}") -fi - -# 5. Package verification -run_check "Package Verification" "cd '$PROJECT_ROOT' && mvn package -DskipTests -q" - -# 6. Dependency check -run_check "Dependency Check" "cd '$PROJECT_ROOT' && mvn dependency:tree -q" - -# 7. SpotBugs/Static analysis (if configured) -if grep -q "spotbugs-maven-plugin" "$PROJECT_ROOT/pom.xml" 2>/dev/null; then - run_check "Static Analysis" "cd '$PROJECT_ROOT' && mvn spotbugs:check -q" -else - CHECK_ITEMS+=("{\"name\":\"Static Analysis\",\"status\":\"SKIP\",\"reason\":\"spotbugs-maven-plugin not configured\"}") -fi - -# 8. Integration test (if exists) -if [ -d "$PROJECT_ROOT/src/test/java" ]; then - run_check "Integration Tests" "cd '$PROJECT_ROOT' && mvn verify -q" -else - CHECK_ITEMS+=("{\"name\":\"Integration Tests\",\"status\":\"SKIP\",\"reason\":\"No integration tests found\"}") -fi - -# Output results -if [ "$OUTPUT_MODE" = "json" ]; then - TOTAL=$((PASS_COUNT + FAIL_COUNT)) - JSON_OUTPUT=$(cat < "$OUTPUT_FILE" - else - echo "$JSON_OUTPUT" - fi -else - echo "==========================================" - echo " Smoke Test Results" - echo "==========================================" - echo "Checked At: $CHECKED_AT" - echo "Checked By: $CHECKED_BY" - echo "------------------------------------------" - echo "Total: $((PASS_COUNT + FAIL_COUNT)) | Passed: $PASS_COUNT | Failed: $FAIL_COUNT" - echo "------------------------------------------" - for item in "${CHECK_ITEMS[@]}"; do - name=$(echo "$item" | grep -o '"name":"[^"]*"' | cut -d'"' -f4) - status=$(echo "$item" | grep -o '"status":"[^"]*"' | cut -d'"' -f4) - if [ "$status" = "PASS" ]; then - echo " [PASS] $name" - elif [ "$status" = "FAIL" ]; then - echo " [FAIL] $name" - else - echo " [SKIP] $name" - fi - done - echo "==========================================" -fi - -# Exit with appropriate code -exit $((FAIL_COUNT > 0 ? 1 : 0)) diff --git a/scripts/smoke-test.sh.test b/scripts/smoke-test.sh.test deleted file mode 100644 index 8694d2f..0000000 --- a/scripts/smoke-test.sh.test +++ /dev/null @@ -1,135 +0,0 @@ -#!/bin/bash -# Smoke Test Verification Script -# Validates smoke-test.sh output format matches verification-report-template.json - -set -e - -SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" -PROJECT_ROOT=$(cd "$SCRIPT_DIR/.." && pwd) -TEST_PASSED=true - -# Colors for output -RED='\033[0;31m' -GREEN='\033[0;32m' -NC='\033[0m' - -pass() { - echo -e "${GREEN}[PASS]${NC} $1" -} - -fail() { - echo -e "${RED}[FAIL]${NC} $1" - TEST_PASSED=false -} - -echo "==========================================" -echo " Smoke Test Script Verification" -echo "==========================================" - -# Test 1: Script exists and is executable -if [ -x "$SCRIPT_DIR/smoke-test.sh" ]; then - pass "smoke-test.sh exists and is executable" -else - fail "smoke-test.sh not found or not executable" -fi - -# Test 2: JSON output contains required fields -JSON_OUTPUT=$("$SCRIPT_DIR/smoke-test.sh" --json 2>/dev/null || echo "") - -if echo "$JSON_OUTPUT" | grep -q '"checkedAt"'; then - pass "JSON output contains checkedAt field" -else - fail "JSON output missing checkedAt field" -fi - -if echo "$JSON_OUTPUT" | grep -q '"checkedBy"'; then - pass "JSON output contains checkedBy field" -else - fail "JSON output missing checkedBy field" -fi - -if echo "$JSON_OUTPUT" | grep -q '"items"'; then - pass "JSON output contains items field" -else - fail "JSON output missing items field" -fi - -if echo "$JSON_OUTPUT" | grep -q '"summary"'; then - pass "JSON output contains summary field" -else - fail "JSON output missing summary field" -fi - -# Test 3: JSON output contains Code Format Compliance item -if echo "$JSON_OUTPUT" | grep -q 'Code Format Compliance'; then - pass "JSON output contains 'Code Format Compliance' item" -else - fail "JSON output missing 'Code Format Compliance' item" -fi - -# Test 4: JSON output contains JavaDoc Existence item -if echo "$JSON_OUTPUT" | grep -q 'JavaDoc Existence'; then - pass "JSON output contains 'JavaDoc Existence' item" -else - fail "JSON output missing 'JavaDoc Existence' item" -fi - -# Test 5: File output works -TEMP_FILE=$(mktemp) -"$SCRIPT_DIR/smoke-test.sh" --json --output "$TEMP_FILE" >/dev/null 2>&1 || true - -if [ -f "$TEMP_FILE" ] && [ -s "$TEMP_FILE" ]; then - if grep -q '"checkedAt"' "$TEMP_FILE"; then - pass "File output contains valid JSON" - else - fail "File output does not contain valid JSON" - fi - rm -f "$TEMP_FILE" -else - fail "File output failed" -fi - -# Test 6: Help option works -HELP_OUTPUT=$("$SCRIPT_DIR/smoke-test.sh" --help 2>/dev/null || echo "") -if echo "$HELP_OUTPUT" | grep -q "json"; then - pass "Help output documents --json option" -else - fail "Help output missing --json option documentation" -fi - -# Test 7: Template file exists -if [ -f "$PROJECT_ROOT/docs/verification-report-template.json" ]; then - pass "verification-report-template.json exists" -else - fail "verification-report-template.json not found" -fi - -# Test 8: Checklist file exists -if [ -f "$PROJECT_ROOT/docs/reviewer-verification-checklist.md" ]; then - pass "reviewer-verification-checklist.md exists" -else - fail "reviewer-verification-checklist.md not found" -fi - -# Test 9: Checklist documents script path -if grep -q "scripts/smoke-test.sh" "$PROJECT_ROOT/docs/reviewer-verification-checklist.md"; then - pass "Checklist documents script path" -else - fail "Checklist missing script path documentation" -fi - -# Test 10: Template documents integration -if grep -q "smoke-test.sh" "$PROJECT_ROOT/docs/verification-report-template.json"; then - pass "Template documents smoke-test.sh integration" -else - fail "Template missing smoke-test.sh integration guide" -fi - -echo "==========================================" -if [ "$TEST_PASSED" = true ]; then - echo -e "${GREEN}All verification tests passed!${NC}" - exit 0 -else - echo -e "${RED}Some verification tests failed!${NC}" - exit 1 -fi diff --git a/src/main/java/com/example/developer/DeveloperRoleSmokeApplication.java b/src/main/java/com/example/developer/DeveloperRoleSmokeApplication.java deleted file mode 100644 index c84ebb8..0000000 --- a/src/main/java/com/example/developer/DeveloperRoleSmokeApplication.java +++ /dev/null @@ -1,12 +0,0 @@ -package com.example.developer; - -import org.springframework.boot.SpringApplication; -import org.springframework.boot.autoconfigure.SpringBootApplication; - -@SpringBootApplication -public class DeveloperRoleSmokeApplication { - - public static void main(String[] args) { - SpringApplication.run(DeveloperRoleSmokeApplication.class, args); - } -} diff --git a/src/main/java/com/example/developer/service/DeveloperService.java b/src/main/java/com/example/developer/service/DeveloperService.java deleted file mode 100644 index 241208c..0000000 --- a/src/main/java/com/example/developer/service/DeveloperService.java +++ /dev/null @@ -1,15 +0,0 @@ -package com.example.developer.service; - -import org.springframework.stereotype.Service; - -@Service -public class DeveloperService { - - public String getRole() { - return "DEVELOPER"; - } - - public boolean isAuthorized(String action) { - return "code".equals(action) || "review".equals(action) || "deploy".equals(action); - } -} diff --git a/src/main/java/com/runtimematrix/dto/ErrorResponse.java b/src/main/java/com/runtimematrix/dto/ErrorResponse.java new file mode 100644 index 0000000..a51512b --- /dev/null +++ b/src/main/java/com/runtimematrix/dto/ErrorResponse.java @@ -0,0 +1,8 @@ +package com.runtimematrix.dto; + +public record ErrorResponse( + String code, + String message, + String timestamp, + String path +) {} diff --git a/src/main/java/com/runtimematrix/exception/BusinessException.java b/src/main/java/com/runtimematrix/exception/BusinessException.java new file mode 100644 index 0000000..9fd77eb --- /dev/null +++ b/src/main/java/com/runtimematrix/exception/BusinessException.java @@ -0,0 +1,29 @@ +package com.runtimematrix.exception; + +import java.time.Instant; + +public abstract class BusinessException extends RuntimeException { + + private final String code; + private final Instant timestamp; + private final String path; + + protected BusinessException(String code, String message, String path) { + super(message); + this.code = code; + this.timestamp = Instant.now(); + this.path = path; + } + + public String getCode() { + return code; + } + + public Instant getTimestamp() { + return timestamp; + } + + public String getPath() { + return path; + } +} diff --git a/src/main/java/com/runtimematrix/exception/GlobalExceptionHandler.java b/src/main/java/com/runtimematrix/exception/GlobalExceptionHandler.java new file mode 100644 index 0000000..3dc965b --- /dev/null +++ b/src/main/java/com/runtimematrix/exception/GlobalExceptionHandler.java @@ -0,0 +1,75 @@ +package com.runtimematrix.exception; + +import com.runtimematrix.dto.ErrorResponse; +import jakarta.servlet.http.HttpServletRequest; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.http.HttpStatus; +import org.springframework.http.ResponseEntity; +import org.springframework.web.bind.MethodArgumentNotValidException; +import org.springframework.web.bind.annotation.ExceptionHandler; +import org.springframework.web.bind.annotation.RestControllerAdvice; + +@RestControllerAdvice +public class GlobalExceptionHandler { + + private static final Logger log = LoggerFactory.getLogger(GlobalExceptionHandler.class); + + @ExceptionHandler(BusinessException.class) + public ResponseEntity handleBusinessException( + BusinessException ex, HttpServletRequest request) { + log.error("Business exception: code={}, message={}", ex.getCode(), ex.getMessage()); + + ErrorResponse response = new ErrorResponse( + ex.getCode(), + ex.getMessage(), + ex.getTimestamp().toString(), + request.getRequestURI() + ); + + HttpStatus status = determineHttpStatus(ex); + return ResponseEntity.status(status).body(response); + } + + @ExceptionHandler(MethodArgumentNotValidException.class) + public ResponseEntity handleValidationException( + MethodArgumentNotValidException ex, HttpServletRequest request) { + String message = ex.getBindingResult().getFieldErrors().stream() + .map(error -> error.getField() + ": " + error.getDefaultMessage()) + .reduce((a, b) -> a + "; " + b) + .orElse("Validation failed"); + + ErrorResponse response = new ErrorResponse( + "VALIDATION_ERROR", + message, + Instant.now().toString(), + request.getRequestURI() + ); + + return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(response); + } + + @ExceptionHandler(Exception.class) + public ResponseEntity handleGenericException( + Exception ex, HttpServletRequest request) { + log.error("Unexpected exception", ex); + + ErrorResponse response = new ErrorResponse( + "ERR_INTERNAL", + "내부 서버 오류가 발생했습니다", + Instant.now().toString(), + request.getRequestURI() + ); + + return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(response); + } + + private HttpStatus determineHttpStatus(BusinessException ex) { + String code = ex.getCode(); + if (code.startsWith("VALIDATION_")) return HttpStatus.BAD_REQUEST; + if (code.startsWith("AUTH_")) return HttpStatus.UNAUTHORIZED; + if (code.startsWith("CONFLICT_")) return HttpStatus.CONFLICT; + if (code.startsWith("ERR_NOT_FOUND")) return HttpStatus.NOT_FOUND; + return HttpStatus.INTERNAL_SERVER_ERROR; + } +} diff --git a/src/main/java/com/runtimematrix/exception/RoleNotFoundException.java b/src/main/java/com/runtimematrix/exception/RoleNotFoundException.java new file mode 100644 index 0000000..f3e2caf --- /dev/null +++ b/src/main/java/com/runtimematrix/exception/RoleNotFoundException.java @@ -0,0 +1,12 @@ +package com.runtimematrix.exception; + +public class RoleNotFoundException extends BusinessException { + + public RoleNotFoundException(Long roleId, String path) { + super( + "ERR_ROLE_NOT_FOUND", + "역할 ID " + roleId + "을 찾을 수 없습니다", + path + ); + } +} diff --git a/src/test/java/com/example/developer/service/DeveloperServiceTest.java b/src/test/java/com/example/developer/service/DeveloperServiceTest.java deleted file mode 100644 index 8e8e303..0000000 --- a/src/test/java/com/example/developer/service/DeveloperServiceTest.java +++ /dev/null @@ -1,44 +0,0 @@ -package com.example.developer.service; - -import org.junit.jupiter.api.Test; -import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.boot.test.context.SpringBootTest; - -import static org.junit.jupiter.api.Assertions.*; - -@SpringBootTest -class DeveloperServiceTest { - - @Autowired - private DeveloperService developerService; - - @Test - void contextLoads() { - assertNotNull(developerService); - } - - @Test - void getRole_returnsDeveloper() { - assertEquals("DEVELOPER", developerService.getRole()); - } - - @Test - void isAuthorized_forCodeAction_returnsTrue() { - assertTrue(developerService.isAuthorized("code")); - } - - @Test - void isAuthorized_forReviewAction_returnsTrue() { - assertTrue(developerService.isAuthorized("review")); - } - - @Test - void isAuthorized_forDeployAction_returnsTrue() { - assertTrue(developerService.isAuthorized("deploy")); - } - - @Test - void isAuthorized_forUnknownAction_returnsFalse() { - assertFalse(developerService.isAuthorized("admin")); - } -} diff --git a/src/test/java/com/runtimematrix/exception/GlobalExceptionHandlerTest.java b/src/test/java/com/runtimematrix/exception/GlobalExceptionHandlerTest.java new file mode 100644 index 0000000..0da51bf --- /dev/null +++ b/src/test/java/com/runtimematrix/exception/GlobalExceptionHandlerTest.java @@ -0,0 +1,26 @@ +package com.runtimematrix.exception; + +import com.runtimematrix.dto.ErrorResponse; +import org.junit.jupiter.api.Test; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest; +import org.springframework.test.web.servlet.MockMvc; + +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; +import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*; + +@WebMvcTest +class GlobalExceptionHandlerTest { + + @Autowired + private MockMvc mockMvc; + + @Test + void businessException_returnsConsistentErrorFormat() throws Exception { + mockMvc.perform(get("/api/v1/roles/999")) + .andExpect(status().isNotFound()) + .andExpect(jsonPath("$.code").value("ERR_ROLE_NOT_FOUND")) + .andExpect(jsonPath("$.timestamp").exists()) + .andExpect(jsonPath("$.path").value("/api/v1/roles/999")); + } +} diff --git a/src/test/java/com/runtimematrix/service/RoleServiceTransactionTest.java b/src/test/java/com/runtimematrix/service/RoleServiceTransactionTest.java new file mode 100644 index 0000000..cd6b579 --- /dev/null +++ b/src/test/java/com/runtimematrix/service/RoleServiceTransactionTest.java @@ -0,0 +1,36 @@ +package com.runtimematrix.service; + +import com.runtimematrix.domain.Role; +import com.runtimematrix.repository.RoleRepository; +import org.junit.jupiter.api.Test; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.context.SpringBootTest; +import org.springframework.transaction.annotation.Transactional; + +import static org.assertj.core.api.Assertions.assertThat; + +@SpringBootTest +class RoleServiceTransactionTest { + + @Autowired + private RoleService roleService; + + @Autowired + private RoleRepository roleRepository; + + @Test + @Transactional(readOnly = true) + void readOnlyTransaction_allowsRead() { + var roles = roleService.findAllRoles(); + assertThat(roles).isNotNull(); + } + + @Test + void createRole_commitsSuccessfully() { + Role role = new Role(null, "TEST_ROLE", "Test Role"); + Role saved = roleService.createRole(role); + + assertThat(saved.getId()).isNotNull(); + assertThat(roleRepository.findById(saved.getId())).isPresent(); + } +}